Fix duplicate attestations error message to be a str, not a tuple #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I imagine someone refactored and moved message out int a variable, but forgot that in that case comma after argument is significant. Fixes pypa#339
dimaqq
referenced
this pull request
Feb 20, 2025
This patch moves said check out of the signing loop and performs the check early in the process. It is then able to report multiple problems in a single error.
Almost: #315. My bad. |
webknjaz
reviewed
Feb 20, 2025
webknjaz
changed the title
webknjaz
added a commit
that referenced
this pull request
Feb 20, 2025
|
Reverted because this was made against the wrong branch. |
|
Oh, sorry! |
bryfox
added a commit
to foxglove/foxglove-python
that referenced
this pull request
Mar 4, 2025
Our most recent publish step failed: https://github.com/foxglove/foxglove-python/actions/runs/13660769163/job/38191137604 We appear to need this fix: pypa/gh-action-pypi-publish#340 ...which is in [unstable/v1](https://github.com/pypa/gh-action-pypi-publish/commits/unstable/v1) but not yet in a versioned release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine someone refactored and moved message out int a variable, but forgot that in that case comma after argument is significant.
Fixes #339