Skip to content

Add switch block in renderCommentContent, see if tsc likes it #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add switch block in renderCommentContent, see if tsc likes it #276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f4871
Add switch block in renderCommentContent, see if tsc likes it
hoodmane Jul 7, 2025
b80fb81
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions sphinx_js/js/convertTopLevel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,16 @@ class PathComputer implements ReflectionVisitor {
*/
function renderCommentContent(content: CommentDisplayPart[]): Description {
return content.map((x): DescriptionItem => {
if (x.kind === "code") {
return { type: "code", code: x.text };
switch (x.kind) {
case "code":
return { type: "code", code: x.text };
case "text":
return { type: "text", text: x.text };
case "inline-tag":
return { type: "text", text: x.text };
case "relative-link":
return { type: "text", text: x.text };
}
if (x.kind === "text") {
return { type: "text", text: x.text };
}
throw new Error("Not implemented");
});
}

Expand Down
Loading