Update default cxxflags equal to cflags #255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
commented
Nov 11, 2025
| "Default: recipe_dir.", | ||
| ), | ||
| cflags: str = typer.Option( | ||
| "", help="Extra compiling flags. Default: SIDE_MODULE_CFLAGS" |
Member
Author
There was a problem hiding this comment.
This is unrelated to this PR. But I think that, as these environment variables are not exposed to the users anymore, it is not very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes default cxxflags to be equal to cflags (except for the
-Ifor CPython). Resolves #251. Note that CXXFLAGS were empty since Pyodide 0.25, which is the minimum version that the current pyodide-build supports.