Fix critical server startup and performance issues #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two critical issues: 1. **Server Startup Fix**: Resolves ValueError preventing server from starting - Add import os statement - Set LOG_LEVEL environment variable to 'INFO' by default - Pass explicit log_level='INFO' parameter to FastMCP constructor - Fixes: \"ValueError: Invalid log level: info. Expected one of: ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL']\" 2. **Critical Performance Fix**: Remove duplicate PDF processing in save_path mode - Previously, PDFs were processed twice when using save_path (lines 47 & 51) - This caused 2x processing time and unnecessary resource usage for large files - Now PDF is processed only once and content reused for file writing These fixes resolve server startup failures and significantly improve performance for file-saving operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two critical issues:
Server Startup Fix: Resolves ValueError preventing server from starting
Critical Performance Fix: Remove duplicate PDF processing in save_path mode
These fixes resolve server startup failures and significantly improve performance for file-saving operations.