Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect core roiSet signal to MDAWidget _core_grid and _core_position #406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Mar 5, 2025

Currently, when the camera ROI is changed, any previously added grid_plan or positions containing a grid_plan subsequence do not automatically update their field of view size.

This PR fixes this bug mentioned in #405 .

closes #405

@fdrgsp fdrgsp added the bug Something isn't working label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (43fd386) to head (817de7a).

Files with missing lines Patch % Lines
src/pymmcore_widgets/mda/_core_positions.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   90.65%   90.64%   -0.02%     
==========================================
  Files          85       85              
  Lines        9362     9383      +21     
==========================================
+ Hits         8487     8505      +18     
- Misses        875      878       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDA widget grid plan does not use the current ROI
1 participant