Implement trie algorithm pattern matching #1592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows matching multiple patterns to a single graph, avoiding repeated comparisons across similar patterns, which should scale nicely with the number of rewrites.
Also, unlike the current unification approach partial matching of Op properties can be done, which is nice as some Ops have many parameters that don't matter for rewrite purposes (such as inplace patterns). PatternSub couldn't handle this logic before.
Finally, this approach should be extendable to handle variadic/associative ops, similar to https://github.com/HPAC/matchpy
📚 Documentation preview 📚: https://pytensor--1592.org.readthedocs.build/en/1592/