Labeled tensors

[ricardoV94]

import numpy as np

from pytensor import function
from pytensor.xtensor.basic import add, exp
from pytensor.xtensor.type import xtensor

x = xtensor("x", dims=("city",), shape=(None,))
y = xtensor("y", dims=("country",), shape=(4,))
z = add(exp(x), exp(y))
assert z.type.dims == ("city", "country")
assert z.type.shape == (None, 4)

fn = function([x, y], z)
fn.dprint(print_type=True)
# XTensorFromTensor{dims=('city', 'country')} [id A] <XTensorType{dtype='float64', shape=(None, 4), dims=('city', 'country')}> 7
#  └─ Add [id B] <Matrix(float64, shape=(?, 4))> 6
#     ├─ Exp [id C] <Matrix(float64, shape=(?, 1))> 5
#     │  └─ ExpandDims{axis=1} [id D] <Matrix(float64, shape=(?, 1))> 3
#     │     └─ TensorFromXTensor [id E] <Vector(float64, shape=(?,))> 1
#     │        └─ x [id F] <XTensorType{dtype='float64', shape=(None,), dims=('city',)}>
#     └─ Exp [id G] <Matrix(float64, shape=(1, 4))> 4
#        └─ ExpandDims{axis=0} [id H] <Matrix(float64, shape=(1, 4))> 2
#           └─ TensorFromXTensor [id I] <Vector(float64, shape=(4,))> 0
#              └─ y [id J] <XTensorType{dtype='float64', shape=(4,), dims=('country',)}>

np.testing.assert_allclose(
    fn(x=np.zeros(3), y=np.zeros(4)),
    np.full((3, 4), 2.0),
)

Strategy

We implement xarray-like dummy Ops that respect / propagate dims semantics, and lower them to regular PyTensor graphs with rewrites.

Note in the example above the dummy TensorFromXtensor and XTensorFromTensor remain in the final graph. If we had created a function with Tensor inputs and outputs that are only then converted (symbolically) to and from xtensor, respectively, the final graph would have no signs of dimension operations, other than how it was constructed.

I suggest registering those rewrites in an xtensor_lowering database.

Coordinates

For now I'm playing with how far we can get without coordinates. This means the graphs produced by an xarray-like syntax are much more amenable to the numpy-like backend of PyTensor. Otherwise it involves a lot of Pandas-like stuff (e.g., Multiindex) that we don't really have. It may be feasible, specially if nothing is symbolic, but... I fear a rabbit hole of edge cases)

Gradients

These ops are currently not differentiable, but one can lower the graph and then call the gradient. I do want to try the lazy grad approach from #788

Help implementing more Ops so we have MVP to try out with PyMC next. We need some Ops

Open a PR on top of this branch, I'll try to merge quickly! Try to make it clean (one commit per Op, unless it's like a factory of related Ops)

Implementing means:

1. Create a dummy Op
2. Create a rewrite that lowers the dummy Op to real tensor operations
   3.1 The rewrites "box" the lower tensor operations between TensorFromXTensor and XTensorFromTensor calls, so that the replacements are valid in terms of types. There are rewrites to remove chains of useless TensorFromXTensor/XTensorFromTensor that should clean up everything in the middle of the graph.
3. Add a test that compares with xarray/xarray_einstants and proves it's correct
4. If you really want, test the error checks (I haven't been doing that)

Interplay between XTensorTypes and TensorTypes / weakly typed inputs

• Symbolic conversion to and from XTensor and Tensor
• Make sure MetaOps accept non-XTensorType scalar inputs
• Make MetaOps (Elemwise / Blockwise) "cast" regular numpy/TensorVariable inputs to XTensorVariable to behave like xarray does (dims are considered to match positionally, try it out).
• Operators as methods (__add__ and the like so you can do x + x)

Meta Ops

• Elemwise (automatically generated, some may fail)
• Blockwise (each Op needs manual curation though)
• XTensorVariable.where (1 or 2, can be implemented with math.switch probably can't support drop=True)
• xtensor.where(3 inputs, just an alias to xtensor.math.switch that should be available at the module level)
• CAReduce (Sum, All, Mean, ...)
• Einsum (probably low priority)
• Scan (a thin wrapper around Scan should be fine, just need to add the time dim to the outputs, and perhaps use that to also align the sequences)

Math stuff

• Cast (it's a parametrized ScalarOp so the general XElemwise logic won't suffice)
• Dot
• Mean/Std/Variance (there's no CAReduce Op corresponding to those)
• Everything that is a blockwise in vanilla pytensor (like all of linalg)
• Argmax / Argmin
• Sort / Argsort?

Shape stuff

• Rename
• Transpose
• ExpandDims
• Squeeze
• swap_dims (should just be a call to Rename)
• Stack (missing adding as method)
• Unstack Add unstack for xtensors #1412
• Concat
• Broadcast_arrays (chaining Elemwise second should achieve this)

Array creation stuff

• ZerosLike / OnesLike (just return self.x * 0, self.x * 0 + 1)? PyTensor will do the right thing when it gets lowered)

Indexing stuff

• __getitem__ + isel Implement indexing operations for XTensorVariables #1429
• __getitem__ + isel for boolean indices (should work fine, just need to test and lift raise error)
• Indexing update (aka set and inc_subtensor)
  It probably makes sense to convert the non-XTensor indices to XTensor indices if they can be rendered equivalent, to reduce logic needed.

RandomVariables

This is quite important, as we'll need those for PyMC models! They are a mix of blockwise + size argument (which can or not be redundant)

Graph transformations

• grad (and jacobian and all that)
• vectorize_graph

---

📚 Documentation preview 📚: https://pytensor--1411.org.readthedocs.build/en/1411/

[codecov]

Codecov Report

Attention: Patch coverage is 78.54046% with 297 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (ff98ab8) to head (7b8877b).

Files with missing lines	Patch %	Lines
pytensor/xtensor/type.py	62.53%	120 Missing and 22 partials ⚠️
pytensor/xtensor/shape.py	78.06%	21 Missing and 22 partials ⚠️
pytensor/xtensor/indexing.py	75.60%	16 Missing and 14 partials ⚠️
pytensor/xtensor/basic.py	75.38%	13 Missing and 3 partials ⚠️
pytensor/xtensor/reduction.py	82.50%	12 Missing and 2 partials ⚠️
pytensor/xtensor/rewriting/reduction.py	79.31%	7 Missing and 5 partials ⚠️
pytensor/xtensor/vectorization.py	82.08%	8 Missing and 4 partials ⚠️
pytensor/xtensor/rewriting/basic.py	80.48%	8 Missing ⚠️
pytensor/xtensor/rewriting/indexing.py	93.02%	3 Missing and 3 partials ⚠️
pytensor/xtensor/linalg.py	86.66%	2 Missing and 2 partials ⚠️
... and 3 more

❌ Your patch check has failed because the patch coverage (78.54%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
- Coverage   82.12%   82.03%   -0.09%     
==========================================
  Files         211      227      +16     
  Lines       49757    51128    +1371     
  Branches     8819     9020     +201     
==========================================
+ Hits        40862    41944    +1082     
- Misses       6715     6926     +211     
- Partials     2180     2258      +78     

Files with missing lines	Coverage Δ
pytensor/tensor/basic.py	91.69% <100.00%> (ø)
pytensor/tensor/extra_ops.py	88.88% <ø> (+0.67%)	⬆️
pytensor/tensor/subtensor.py	89.98% <ø> (ø)
pytensor/xtensor/rewriting/__init__.py	100.00% <100.00%> (ø)
pytensor/xtensor/rewriting/shape.py	100.00% <100.00%> (ø)
pytensor/xtensor/rewriting/vectorization.py	100.00% <100.00%> (ø)
pytensor/xtensor/special.py	60.00% <60.00%> (ø)
pytensor/xtensor/linalg.py	86.66% <86.66%> (ø)
pytensor/xtensor/math.py	96.63% <96.63%> (ø)
pytensor/xtensor/rewriting/utils.py	69.23% <69.23%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ricardoV94]

If anybody wants to fix mypy that's very welcome :)

[twiecki]

new files need a license.

[ricardoV94]

@lucianopaz can we bring your pre-commit hook over?

[lucianopaz]

Sure

[ricardoV94]

Can be a separate PR, wouldn't be surprised if have files missing it in main