Skip to content

Conversation

@ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Dec 18, 2025

Closes #7934

@ricardoV94 ricardoV94 added release pytensor major Include in major changes release notes section labels Dec 18, 2025
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dependency branch from 2e8324a to 0560f60 Compare December 18, 2025 09:31
@ricardoV94 ricardoV94 mentioned this pull request Dec 18, 2025
11 tasks
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dependency branch from 0560f60 to cec9700 Compare December 18, 2025 13:40
Co-authored-by: PatrickRobotham
Co-authored-by: Michal-Novomestsky
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dependency branch from cec9700 to 37b7ad5 Compare December 18, 2025 15:03
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (cadb97a) to head (1a549c9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pymc/distributions/simulator.py 0.00% 2 Missing ⚠️
pymc/variational/approximations.py 0.00% 1 Missing ⚠️
pymc/variational/opvi.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8010      +/-   ##
==========================================
+ Coverage   90.22%   91.45%   +1.22%     
==========================================
  Files         116      116              
  Lines       18972    18971       -1     
==========================================
+ Hits        17117    17349     +232     
+ Misses       1855     1622     -233     
Files with missing lines Coverage Δ
pymc/distributions/multivariate.py 93.92% <100.00%> (+0.01%) ⬆️
pymc/distributions/shape_utils.py 91.87% <100.00%> (ø)
pymc/distributions/timeseries.py 94.57% <100.00%> (-0.05%) ⬇️
pymc/logprob/transforms.py 95.43% <100.00%> (ø)
pymc/pytensorf.py 88.11% <100.00%> (ø)
pymc/smc/sampling.py 77.08% <100.00%> (+1.38%) ⬆️
pymc/variational/operators.py 93.47% <100.00%> (ø)
pymc/variational/approximations.py 90.86% <0.00%> (ø)
pymc/variational/opvi.py 86.75% <50.00%> (ø)
pymc/distributions/simulator.py 84.28% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the installation issues about dependencies or installation label Dec 19, 2025
[
pytest.param(
"float32",
marks=pytest.mark.xfail(
Copy link
Member Author

@ricardoV94 ricardoV94 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the issue locally. CI is running on 3.14. Installing the same numba/scipy versions on my local 3.12 wasn't enough to replicate. I wouldn't block the dependency bump on this as it's rather niche functionality.

Tracking issue: #8012

@ricardoV94
Copy link
Member Author

ricardoV94 commented Dec 19, 2025

RTD is failing with a strange conda error?

https://app.readthedocs.org/projects/pymc/builds/30757275/

error    Error opening "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/pkgs/pytensor-2.36.0-py314h8fa1eac_1.conda": No such file or directory
error    File not valid: SHA256 sum doesn't match expectation "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/pkgs/pytensor-2.36.0-py314h8fa1eac_1.conda"
    Expected: 0c2f7154116702b630c239df3780ec9963c8de36876f6cb31e7632a77a80dd53
    Actual: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
    
# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
    Traceback (most recent call last):
      File "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/lib/python3.9/site-packages/conda/exceptions.py", line 1079, in __call__
        return func(*args, **kwargs)
      File "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/lib/python3.9/site-packages/conda_env/cli/main.py", line 80, in do_call
        exit_code = getattr(module, func_name)(args, parser)
      File "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/lib/python3.9/site-packages/conda_env/cli/main_create.py", line 141, in execute
        result[installer_type] = installer.install(prefix, pkg_specs, args, env)
      File "/home/docs/.asdf/installs/python/mambaforge-4.10.3-10/lib/python3.9/site-packages/mamba/mamba_env.py", line 125, in mamba_install
        downloaded = transaction.prompt(repos)
    RuntimeError: Found incorrect download: pytensor. Aborting
`$ /home/docs/.asdf/installs/python/mambaforge-4.10.3-10/bin/mamba create --quiet --name 8010 --file conda-envs/environment-docs.yml`

CC @maresb @OriolAbril

Maybe there's some cache in the CI that needs to be erased?

pt.as_tensor_variable(np.array([-2, -1])),
],
name="xs",
# There's a bug in the ordering of outputs when there's a mapped `None` output
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug is pymc-devs/pytensor#1796

Hopefully we can fix in the next release and update the remaining tests to the new API

@OriolAbril
Copy link
Member

RTD is failing with a strange conda error?

I triggered a re-run which seems to be working and already created the env successfully, no idea what could have caused that particular issue though. AFAIK there is no caching on RTD and even if there were, the previous builds used the same exact conda build

@ricardoV94 ricardoV94 marked this pull request as ready for review December 19, 2025 17:02
@ricardoV94
Copy link
Member Author

Thanks @OriolAbril

@zaxtax zaxtax self-requested a review December 21, 2025 12:28
@ricardoV94 ricardoV94 merged commit adb79be into pymc-devs:main Dec 21, 2025
26 checks passed
@ricardoV94 ricardoV94 deleted the bump_pytensor_dependency branch December 21, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installation issues about dependencies or installation major Include in major changes release notes section pytensor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyMC not installable in Python 3.14 yet

4 participants