-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Bump PyTensor dependency and support Python 3.14 #8010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump PyTensor dependency and support Python 3.14 #8010
Conversation
2e8324a to
0560f60
Compare
0560f60 to
cec9700
Compare
Co-authored-by: PatrickRobotham
Co-authored-by: Michal-Novomestsky
cec9700 to
37b7ad5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8010 +/- ##
==========================================
+ Coverage 90.22% 91.45% +1.22%
==========================================
Files 116 116
Lines 18972 18971 -1
==========================================
+ Hits 17117 17349 +232
+ Misses 1855 1622 -233
🚀 New features to boost your workflow:
|
4d5dd2d to
1a549c9
Compare
| [ | ||
| pytest.param( | ||
| "float32", | ||
| marks=pytest.mark.xfail( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't reproduce the issue locally. CI is running on 3.14. Installing the same numba/scipy versions on my local 3.12 wasn't enough to replicate. I wouldn't block the dependency bump on this as it's rather niche functionality.
Tracking issue: #8012
|
RTD is failing with a strange conda error? https://app.readthedocs.org/projects/pymc/builds/30757275/ Maybe there's some cache in the CI that needs to be erased? |
| pt.as_tensor_variable(np.array([-2, -1])), | ||
| ], | ||
| name="xs", | ||
| # There's a bug in the ordering of outputs when there's a mapped `None` output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug is pymc-devs/pytensor#1796
Hopefully we can fix in the next release and update the remaining tests to the new API
I triggered a re-run which seems to be working and already created the env successfully, no idea what could have caused that particular issue though. AFAIK there is no caching on RTD and even if there were, the previous builds used the same exact conda build |
|
Thanks @OriolAbril |
Closes #7934