-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow debug evaling IR logp graphs #7666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardoV94
merged 1 commit into
pymc-devs:main
from
ricardoV94:allow_debugging_logp_graphs
Jul 15, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,13 +236,16 @@ class ValuedRV(Op): | |
and breaking the dependency of `b` on `a`. The new nodes isolate the graphs between conditioning points. | ||
""" | ||
|
||
view_map = {0: [0]} | ||
|
||
def make_node(self, rv, value): | ||
assert isinstance(rv, Variable) | ||
assert isinstance(value, Variable) | ||
return Apply(self, [rv, value], [rv.type(name=rv.name)]) | ||
|
||
def perform(self, node, inputs, out): | ||
raise NotImplementedError("ValuedVar should not be present in the final graph!") | ||
warnings.warn("ValuedVar should not be present in the final graph!") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we be logging instead of warning so people can more easily turn it off? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I want this to be loud, because it shouldn't be in the final graph. |
||
out[0][0] = inputs[0] | ||
|
||
def infer_shape(self, fgraph, node, input_shapes): | ||
return [input_shapes[0]] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs view_map so PyTensor knows not to do inplace operations on this. The other Op already had the view_map defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that you have to use view_map to do that. Somewhat hidden functionality? I thought pytensor only does inplace on things that proactively define a destroy_map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't say this output returns a view of the input, and this output is not itself a graph output, PyTensor will assume it can be safely destroyed as it is just an intermediate operation.