Skip to content

Add support for marimo notebooks #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2025

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jun 22, 2025

Struggle with this a bit. Not sure if there is an issue with callback being called from rust

Here is the code from their end:

https://github.com/marimo-team/marimo/blob/cdcb42ce8016d5f149ed06f5f36b6728eef81e38/marimo/_runtime/output/_output.py?plain=1#L28-L49

Closes #223

@williambdean
Copy link
Contributor Author

williambdean commented Jun 22, 2025

@williambdean
Copy link
Contributor Author

Got it to work!

@williambdean
Copy link
Contributor Author

Screen.Recording.2025-06-21.at.11.33.15.PM.mov

@williambdean williambdean marked this pull request as ready for review June 22, 2025 03:36
Copy link
Member

@aseyboldt aseyboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's really cool!

Just one minor nitpick: maybe prefix the new marimo-related functions with _mo or so, to mark them as private and make the context a bit clearer?

@williambdean
Copy link
Contributor Author

Yes. Will do

@williambdean
Copy link
Contributor Author

Feedback addressed. Thanks for the review!

@aseyboldt aseyboldt merged commit 5ad9c14 into pymc-devs:main Jun 22, 2025
8 checks passed
@williambdean williambdean deleted the marimo-support branch June 22, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support in marimo notebook
2 participants