Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for pd.Series.select #1446

Merged
merged 8 commits into from
Feb 22, 2025

Conversation

samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • Add support for pd.Series.select

This PR resolves #1394 .

Please tag maintainers to review.

@samukweku samukweku requested review from ericmjl, Zeroto521, thatlittleboy and a team February 21, 2025 23:19
@samukweku samukweku self-assigned this Feb 21, 2025
@samukweku samukweku linked an issue Feb 21, 2025 that may be closed by this pull request
@ericmjl
Copy link
Member

ericmjl commented Feb 22, 2025

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (6e77fbc) to head (4cfe8a1).
Report is 47 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1446      +/-   ##
==========================================
- Coverage   89.07%   83.29%   -5.79%     
==========================================
  Files          87       87              
  Lines        5374     6392    +1018     
==========================================
+ Hits         4787     5324     +537     
- Misses        587     1068     +481     

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samukweku samukweku merged commit 6ced169 into dev Feb 22, 2025
4 checks passed
@samukweku samukweku deleted the 1394-extend-the-select-function-to-pdseries branch February 22, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend the select function to pd.Series
2 participants