Skip to content

[BUG] address issue #1201 #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions AUTHORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,7 @@ Contributors
- [@gahjelle](https://github.com/gahjelle) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Agahjelle)
- [@ethompsy](https://github.com/ethompsy) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Aethompsy)
- [@apatao](https://github.com/apatao) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Aapatao)
- [@OdinTech3](https://github.com/OdinTech3) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/pull/1094)
- [@asmirnov69](https://github.com/asmirnov69) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues/1059)
- [@OdinTech3](https://github.com/OdinTech3) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%OdinTech3)
- [@asmirnov69](https://github.com/asmirnov69) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%asmirnov69)
- [@xujiboy](https://github.com/xujiboy) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%xujiboy)
- [@joranbeasley](https://github.com/joranbeasley) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%joranbeasley)
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- [INF] Replace `pytest.ini` file with `pyproject.toml` file. PR #1204 @Zeroto521
- [INF] Extract docstrings tests from all tests. PR #1205 @Zeroto521
- [BUG] address the `TypeError` when importing v0.24.0 (issue #1201 @xujiboy and @joranbeasley)

## [v0.24.0] - 2022-11-12

Expand Down
2 changes: 1 addition & 1 deletion janitor/functions/conditional_join.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations
import operator
from enum import Enum
from typing import Union, Any, Optional, Hashable, Literal

import numpy as np
import pandas as pd
import pandas_flavor as pf
Expand Down
2 changes: 2 additions & 0 deletions janitor/functions/utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""Utility functions for all of the functions submodule."""

from __future__ import annotations
import fnmatch
import warnings
from collections.abc import Callable as dispatch_callable
Expand Down
5 changes: 3 additions & 2 deletions janitor/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
Lazy loading used here to speed up imports.
"""

from __future__ import annotations
import os
import sys
import socket
from typing import Callable, Dict, Iterable, Union
from typing import Callable, Dict, Iterable, Union, List
from functools import singledispatch, wraps
from warnings import warn

Expand Down Expand Up @@ -213,7 +214,7 @@ def idempotent(func: Callable, df: pd.DataFrame, *args, **kwargs):


def deprecated_kwargs(
*arguments: list[str],
*arguments: List[str],
message: str = (
"The keyword argument '{argument}' of '{func_name}' is deprecated."
),
Expand Down