Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #1202

Closed
wants to merge 2 commits into from
Closed

Conversation

joranbeasley
Copy link

resolves #1201

simple typo

PR Description

Please describe the changes proposed in the pull request:

This PR resolves #(put issue number here, and remove parentheses).

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #1202 (b5ed5a5) into dev (634093f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1202      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.03%     
==========================================
  Files          76       76              
  Lines        3522     3522              
==========================================
- Hits         3453     3452       -1     
- Misses         69       70       +1     

@joranbeasley
Copy link
Author

@ericmjl

@samukweku
Copy link
Collaborator

@Zeroto521 thoughts?

@ericmjl ericmjl mentioned this pull request Nov 24, 2022
3 tasks
@ericmjl
Copy link
Member

ericmjl commented Nov 24, 2022

@joranbeasley I just realized that this PR is a duplicate PR of #1203.

As mentioned in my comment on that PR, I'd like to nonetheless credit you in the changelog for taking the time to make the PR. As such, I will close this PR once the other is merged. That said, you'll be listed alongside @xujiboy for the effort you took here.

@Zeroto521 Zeroto521 closed this Nov 27, 2022
@joranbeasley joranbeasley deleted the patch-1 branch November 28, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]import janitor causing TypeError
4 participants