Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Fix for Issue #1184 #1186

Merged
merged 7 commits into from
Nov 7, 2022
Merged

[TST] Fix for Issue #1184 #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
644f068
add fix for GH#1184
samukweku Nov 1, 2022
c0650eb
changelog
samukweku Nov 1, 2022
d04f8a5
fix grammar
samukweku Nov 1, 2022
a147340
clearer comments
samukweku Nov 1, 2022
3486512
Merge branch 'dev' of https://github.com/pyjanitor-devs/pyjanitor int…
samukweku Nov 2, 2022
c46d596
update changelog
samukweku Nov 2, 2022
30b821b
Merge branch 'dev' into samukweku/fill_timestamp
ericmjl Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
- [TST] Compat with macos and window, to fix `FailedHealthCheck` Issue #1181 @Zeroto521
- [INF] Merge two docs CIs (`docs-preview.yml` and `docs.yml`) to one. And add `documentation` pytest mark. PR #1183 @Zeroto521
- [INF] Merge `codecov.yml` (only works for the dev branch pushing event) into `tests.yml` (only works for PR event). PR #1185 @Zeroto521
- [TST] Fix failure for test/timeseries/test_fill_missing_timestamp. Issue #1184 @samukweku
- [BUG] Import `DataDescription` to fix: `AttributeError: 'DataFrame' object has no attribute 'data_description'`. PR #1191 @Zeroto521

## [v0.23.1] - 2022-05-03
Expand Down
11 changes: 10 additions & 1 deletion tests/timeseries/test_fill_missing_timestamps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ def test_fill_missing_timestamps(timeseries_dataframe):
df1 = timeseries_dataframe.drop(timeseries_dataframe.index[random_number])

# Fill missing timestamps
result = fill_missing_timestamps(df1, frequency="1H")
# fix for GH#1184 is to use the start and end from
# timeseries_dataframe
# imagine that the last row of df1 is removed, or the first entry
# the length check in the assert line will fail
result = fill_missing_timestamps(
df1,
frequency="1H",
first_time_stamp=timeseries_dataframe.index.min(),
last_time_stamp=timeseries_dataframe.index.max(),
)

# Testing if the missing timestamp has been filled
assert len(result) == len(timeseries_dataframe)
Expand Down