Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Update _select_column_names test case #1152

Closed

Conversation

Zeroto521
Copy link
Member

@Zeroto521 Zeroto521 commented Aug 19, 2022

PR Description

Please describe the changes proposed in the pull request:

the return type of _select_column_names is a list.
A list can't compare with pandas.index via assert_index_equal.

And also rename tests/utils/test__select_column.pytests/utils/test_select_column.py, keep single _.

This PR resolves #1143.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1152 (74aa528) into dev (a027753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1152   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          77       77           
  Lines        3240     3240           
=======================================
  Hits         3154     3154           
  Misses         86       86           

@Zeroto521
Copy link
Member Author

The test file name of _select_column_names should be test__select_column_names, because _select_column_names method name strats with _.

@Zeroto521 Zeroto521 changed the title TST: Update _select_column_names test case [TST] Update _select_column_names test case Aug 20, 2022
@Zeroto521
Copy link
Member Author

It seems that this problem was fixed on #1155.

@Zeroto521 Zeroto521 closed this Aug 21, 2022
@Zeroto521 Zeroto521 deleted the test/test_select_column branch August 21, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants