-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INF] Set multi-test env to compat dependency and system #1143
Open
Zeroto521
wants to merge
48
commits into
pyjanitor-devs:dev
Choose a base branch
from
Zeroto521:ci/testing-env
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
b8c9803
Set dependency latest version env
Zeroto521 a61d3c4
Add marks
Zeroto521 9986e8e
Test latest env
Zeroto521 2c38994
require minimal pyspark is 3.2.2
Zeroto521 f71cefc
update env name
Zeroto521 5192b90
empty commit to trigger ci
Zeroto521 287ee5b
remove duplicate `-`
Zeroto521 0cd95e5
Merge remote-tracking branch 'upstream/dev' into ci/testing-env
Zeroto521 5b8a09a
skip `test_docs_general_functions_present`
Zeroto521 90ce9f0
ignore flake
Zeroto521 f236624
still build the documentation
Zeroto521 b155722
Update skipif logic
Zeroto521 5b75198
test built result on 'build documentation' ci
Zeroto521 18f34e0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 263aaa2
lint code
Zeroto521 3cc6c78
Merge branch 'ci/testing-env' of https://github.com/Zeroto521/pyjanit…
Zeroto521 4d26689
simplify a bit
Zeroto521 4c429e6
Merge branch 'pyjanitor-devs:dev' into ci/testing-env
Zeroto521 b92925a
Merge branch 'pyjanitor-devs:dev' into ci/testing-env
Zeroto521 4b1e2e9
Remove py3.6 and py3.7
Zeroto521 bd99a1a
Merge branch 'pyjanitor-devs:dev' into ci/testing-env
Zeroto521 9330f43
Merge branch 'pyjanitor-devs:dev' into ci/testing-env
Zeroto521 34a415a
Merge remote-tracking branch 'upstream/dev' into ci/testing-env
Zeroto521 f2aec0b
Update name
Zeroto521 1391751
lint codes
Zeroto521 30cc453
Add `lazy_loader` into env
Zeroto521 609465b
reversed changes to `test_documentation_build.py`
Zeroto521 8079eca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f6bf739
Update CHANGELOG.md
Zeroto521 240acbf
Merge branch 'ci/testing-env' of https://github.com/Zeroto521/pyjanit…
Zeroto521 208706a
fix `hypothesis.errors.FailedHealthCheck`
Zeroto521 aad0f47
fix `hypothesis.errors.FailedHealthCheck`
Zeroto521 3a157ed
fix `hypothesis.errors.FailedHealthCheck`
Zeroto521 5ee95d6
fix `hypothesis.errors.FailedHealthCheck`
Zeroto521 2405a07
Merge branch 'dev' into ci/testing-env
Zeroto521 bec7293
fix `hypothesis.errors.FailedHealthCheck`
Zeroto521 d13fb8d
add fix for GH#1184
samukweku 0249ce8
Merge branch 'ci/testing-env' of https://github.com/Zeroto521/pyjanit…
Zeroto521 fc4ba6c
Merge remote-tracking branch 'upstream/dev' into ci/testing-env
Zeroto521 ad217f2
Fix `hypothesis.errors.Flaky`
Zeroto521 5397c1b
Merge branch 'dev' into ci/testing-env
Zeroto521 6da2269
Merge branch 'dev' into ci/testing-env
Zeroto521 334cee5
Merge branch 'ci/testing-env' of https://github.com/Zeroto521/pyjanit…
Zeroto521 788ad2d
Merge remote-tracking branch 'upstream/dev' into ci/testing-env
Zeroto521 03f4f52
Add `pytest-doctestplus`
Zeroto521 a48292d
docstrings tests will happen on some specific conditions
Zeroto521 e107901
Merge branch 'dev' into ci/testing-env
ericmjl 1378f54
Merge branch 'dev' into ci/testing-env
Zeroto521 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: pyjanitor tests | ||
name: tests | ||
|
||
on: | ||
push: | ||
|
@@ -14,18 +14,28 @@ concurrency: | |
|
||
jobs: | ||
run-tests: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
test-subset: ["turtle", "not turtle"] | ||
runs-on: ubuntu-latest | ||
name: Run pyjanitor test suite | ||
name: ${{ matrix.os }}, ${{ matrix.python-version }}, ${{ matrix.env }} | ||
runs-on: ${{ matrix.os }} | ||
|
||
# https://github.com/marketplace/actions/setup-miniconda#use-a-default-shell | ||
defaults: | ||
run: | ||
shell: bash -l {0} | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: | ||
- ubuntu-latest | ||
- macos-latest | ||
- windows-latest | ||
dev: [false] | ||
python-version: | ||
- "3.8" | ||
- "3.9" | ||
- "3.10" | ||
env: [ci/envs/latest.yaml] | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
@@ -36,18 +46,21 @@ jobs: | |
with: | ||
auto-update-conda: true | ||
miniforge-variant: Mambaforge | ||
channels: conda-forge | ||
environment-file: environment-dev.yml | ||
environment-file: ${{ matrix.env }} | ||
use-mamba: true | ||
|
||
- name: Install pyjanitor | ||
run: python -m pip install -e . | ||
|
||
- name: Run docstrings tests | ||
if: ${{ contains(matrix.env, 'latest.yaml') && contains(matrix.os, 'ubuntu') }} | ||
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml --doctest-only janitor | ||
|
||
- name: Run unit tests | ||
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml tests -m "${{ matrix.test-subset }}" | ||
- name: Run not turtle unit tests | ||
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml tests -m "not turtle" | ||
|
||
- name: Run turtle unit tests | ||
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml tests -m "turtle" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Historically we've been able to reduce testing time by running the |
||
|
||
# https://github.com/codecov/codecov-action | ||
- name: Upload code coverage | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: pyjanitor-test | ||
channels: | ||
- conda-forge | ||
dependencies: | ||
# required | ||
- pandas | ||
- pandas-flavor | ||
- multipledispatch | ||
- lazy_loader | ||
- scipy # math, functions | ||
|
||
# optional | ||
- natsort # functions | ||
- numba # functions | ||
- biopython # biology | ||
- rdkit # chemistry | ||
- tqdm # chemistry | ||
- unyt # engineering | ||
- requests # finance | ||
- pyspark>=3.2.2 | ||
- xarray | ||
# io | ||
- openpyxl | ||
- xlrd | ||
|
||
# testing | ||
- pytest | ||
- pytest-cov | ||
- pytest-xdist | ||
- pytest-doctestplus | ||
- hypothesis | ||
- pandas-vet | ||
- interrogate |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zeroto521 would you recommend also testing on the development environment as defined in
environment-dev.yml
?