-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INF] Set independent environment for building documentation #1141
[INF] Set independent environment for building documentation #1141
Conversation
@@ -22,16 +22,12 @@ jobs: | |||
with: | |||
auto-update-conda: true | |||
miniforge-variant: Mambaforge | |||
channels: conda-forge | |||
activate-environment: pyjanitor-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of channels and activate-environment use the variable of mkdocs/environment.yml
use-mamba: true | ||
|
||
- name: Build docs | ||
run: | | ||
conda activate pyjanitor-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default will activate that env
Codecov Report
@@ Coverage Diff @@
## dev #1141 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 77 77
Lines 3240 3240
=======================================
Hits 3154 3154
Misses 86 86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one change request, and then let's merge!
Co-authored-by: Eric Ma <[email protected]>
Why this test case (tests/functions/test_conditional_join.py::test_multiple_eqs_extension_array) failed in https://github.com/pyjanitor-devs/pyjanitor/runs/7761821318?check_suite_focus=true but passed now? |
I'm not sure, @Zeroto521 - some tests may be flaky, I guess. Usually a re-run of the CI might do the trick. With everything green, I'm happy to merge! |
PR Description
Please describe the changes proposed in the pull request:
/environment-dev.yml is complex.
It's used for building doc, setting developer local env, and setting ci test env.
This file becomes big and big and hard to understand.
Part of #1133.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.