[DOC] Fix min_max_scale docstrings rendering
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeroto521
commented
Jun 15, 2022
| *old_feature_range, | ||
| *feature_range, | ||
| ) | ||
|
|
||
| return df | ||
|
|
||
|
|
||
| def min_max_value(df: pd.DataFrame, jointly: bool) -> tuple: |
There was a problem hiding this comment.
functions/init.py only imports min_max_scale.
But the docstring of inner methods would be rendered by mkdocs.
This behavior is quite different to sphinx.
Codecov Report
@@ Coverage Diff @@
## dev #1123 +/- ##
==========================================
- Coverage 97.99% 97.96% -0.04%
==========================================
Files 77 77
Lines 3198 3198
==========================================
- Hits 3134 3133 -1
- Misses 64 65 +1 |
samukweku
reviewed
Jun 15, 2022
samukweku
approved these changes
Jun 16, 2022
ericmjl
approved these changes
Jun 16, 2022
|
@samukweku please do the honors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #1112.
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.