Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring update #1100

Merged
merged 2 commits into from
May 10, 2022
Merged

docstring update #1100

merged 2 commits into from
May 10, 2022

Conversation

samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • docstrings cleanup for fill_direction, fill_empty, update_where

This PR relates to #972 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
leemaguire Lee Maguire
@samukweku samukweku requested review from ericmjl and thatlittleboy May 8, 2022 06:07
@samukweku samukweku self-assigned this May 8, 2022

Verified

This commit was signed with the committer’s verified signature.
leemaguire Lee Maguire
@ericmjl
Copy link
Member

ericmjl commented May 8, 2022

@samukweku
Copy link
Collaborator Author

@ericmjl / @thatlittleboy @pyjanitor-devs/core-devs pls what am I missing regarding the docs build; the preview is not changing to reflect the latest updates

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #1100 (4a0ba7e) into dev (5dfc402) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1100      +/-   ##
==========================================
- Coverage   97.75%   97.72%   -0.04%     
==========================================
  Files          77       77              
  Lines        3121     3121              
==========================================
- Hits         3051     3050       -1     
- Misses         70       71       +1     

@thatlittleboy
Copy link
Contributor

@ericmjl / @thatlittleboy @pyjanitor-devs/core-devs pls what am I missing regarding the docs build; the preview is not changing to reflect the latest updates

@samukweku The link for this PR https://deploy-preview-1100--pyjanitor.netlify.app/ contains the latest updates as far as I can see.

image

Copy link
Contributor

@thatlittleboy thatlittleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! It's a nice and small and self-contained update. Thank you, @samukweku!

@ericmjl
Copy link
Member

ericmjl commented May 10, 2022

We don't have to worry about codecov, it's being wonky again lol.

@ericmjl ericmjl merged commit 4bcfd6c into dev May 10, 2022
@ericmjl ericmjl deleted the samukweku/docfix branch May 10, 2022 23:32
@samukweku
Copy link
Collaborator Author

Approving! It's a nice and small and self-contained update. Thank you, @samukweku!

I'll keep this in mind going forward 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants