Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Method-chaining examples for fill.py #1079

Merged
merged 6 commits into from
May 2, 2022

Conversation

Econundrums
Copy link
Contributor

@Econundrums Econundrums commented May 2, 2022

PR Description

Please describe the changes proposed in the pull request:

Provided method chaining examples for the following

  • fill_empty
  • fill_direction

This PR is related to #972.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1079 (0cdbdea) into dev (34658b3) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1079      +/-   ##
==========================================
- Coverage   97.75%   97.69%   -0.07%     
==========================================
  Files          77       77              
  Lines        3121     3121              
==========================================
- Hits         3051     3049       -2     
- Misses         70       72       +2     

@ericmjl ericmjl merged commit 2c46b15 into pyjanitor-devs:dev May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants