Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extend fill_empty's column_names type range #1014

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

Zeroto521
Copy link
Member

@Zeroto521 Zeroto521 commented Feb 9, 2022

PR Description

Please describe the changes proposed in the pull request:

  • Let column_names support more type range, from list & tuple to Iterable.

This PR resolves #998.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@Zeroto521 Zeroto521 changed the title [ENH] Extend fill_empty's column_names type range [BUG] Extend fill_empty's column_names type range Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1014 (a4a8b4f) into dev (d3146bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1014   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          77       77           
  Lines        2835     2836    +1     
=======================================
+ Hits         2737     2738    +1     
  Misses         98       98           

@ericmjl
Copy link
Member

ericmjl commented Feb 10, 2022

@Zeroto521 I'd love to merge, but before we do so, would love to hear your thoughts on the above discussion point!

@ericmjl
Copy link
Member

ericmjl commented Feb 10, 2022

Thank you, @Zeroto521 for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Extend fill_empty's column_names type range
4 participants