Skip to content

Conversation

e-dong
Copy link

@e-dong e-dong commented Feb 22, 2024

No description provided.

@e-dong e-dong marked this pull request as draft February 22, 2024 11:30
@e-dong
Copy link
Author

e-dong commented Feb 22, 2024

@pmp-p

TO DOs

  • test loop handling for number of repeated events
  • test event as an object type
  • test timer cancel
  • test timer repeated call

Copy link
Member

@pmp-p pmp-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing against pygame-web/platform_wasm#1

@pmp-p
Copy link
Member

pmp-p commented Feb 22, 2024

just missing a call to pygame.init()

@e-dong
Copy link
Author

e-dong commented Feb 22, 2024

just missing a call to pygame.init()

and updating testsuite.py I assume

@e-dong e-dong marked this pull request as ready for review February 22, 2024 13:25
@e-dong
Copy link
Author

e-dong commented Feb 22, 2024

@pmp-p Do the showcase scripts target pygbag stable or git?

@pmp-p
Copy link
Member

pmp-p commented Feb 23, 2024

git, i should have made a 0.9 release already but i'm waiting for that thread stuff + test. Because it is actually the most complex tests to have and 0.9-1.0 cycle will be all about testsuites.

@e-dong
Copy link
Author

e-dong commented Feb 23, 2024

git, i should have made a 0.9 release already but i'm waiting for that thread stuff + test. Because it is actually the most complex tests to have and 0.9-1.0 cycle will be all about testsuites.

Ooh gotcha, thanks I will update my tests, since I was using stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants