Skip to content

Conversation

Starbuck5
Copy link
Member

Adds on to #3464 with 2 tests that go to the heart of the issue and make sure transform functions are returning the correct palettes.

@Starbuck5 Starbuck5 requested a review from a team as a code owner June 3, 2025 08:06
@Starbuck5 Starbuck5 added tests tests (module) transform pygame.transform labels Jun 3, 2025
@ankith26
Copy link
Member

ankith26 commented Jun 3, 2025

Now that andrews PR is merged, can you remove the redundant commit off this PR?

Adds tests for two selected transform functions (scale and invert) to check some palette behavior, most importantly that the output surfaces have the same palettes as the input ones.
@ankith26 ankith26 force-pushed the transform-palette-tests branch from 6542a21 to a917110 Compare June 4, 2025 19:29
@oddbookworm oddbookworm added this to the 2.5.5 milestone Jun 5, 2025
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! 🎉

@ankith26 ankith26 merged commit ffcda0d into pygame-community:main Jun 5, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests tests (module) transform pygame.transform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants