Add Color.hex
#3379
Open
Add Color.hex
#3379
+93
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damusss
added
New API
ankith26
reviewed
Mar 11, 2025
ankith26
approved these changes
Mar 23, 2025
Matiiss
approved these changes
Mar 24, 2025
docs/reST/ref/color.rst
Outdated
| | :sl:`Gets or sets the stringified hexadecimal representation of the Color.` | ||
| | :sg:`hex -> str` | ||
|
|
||
| The strigified hexadecimal representation of the Color. The hexadecimal string |
docs/reST/ref/color.rst
Outdated
| | :sg:`hex -> str` | ||
|
|
||
| The strigified hexadecimal representation of the Color. The hexadecimal string | ||
| is formatted as ``"#rrggbbaa"`` where rr, gg, bb, and aa are 2 digits hex numbers |
There was a problem hiding this comment.
digits -> digit
optional: 2 -> two
|
all suggestions are good I'll fix them today |
|
The latest commit broke formatting of a test file. |
This little maneuver took 15 hours! on my Android
|
Checks seem to be failing because of a bug in package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the New API routine for this property. FAQ below.
Why, if it can be done in one line?
That's not a reason not to add a shortcut. Other color shortcuts like Color.normalized can be achieved in one line aswell, plus, how to get the Color hex with one line is not very straight forward.
Can't you use the built in
hexfunction?That function wasn't made for correct representation of hex colors, so
Color(hex(Color))can easily error, for example in the following cases:hex(Color(1, 2, 3)) -> "0x10203ff"(no trailing zero; ValueError) orhex(Color(0, 0, 0, 255)) -> "'0xff"(not long enough; ValueError).