Skip to content

Commit

Permalink
Merge pull request #432 from fchapoton/typos1
Browse files Browse the repository at this point in the history
fix some typos and rst issues
  • Loading branch information
arsenovic authored Dec 8, 2024
2 parents 6939f2a + eb59347 commit 9e47ec2
Show file tree
Hide file tree
Showing 12 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion clifford/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ def conformalize(layout: Layout, added_sig=[1, -1], *, mvClass=MultiVector, **kw
layout of the GA to conformalize (the base)
added_sig: list-like
list of +1, -1 denoted the added signatures
**kwargs :
``**kwargs`` :
extra arguments to pass on into the :class:`Layout` constructor.
Returns
Expand Down
2 changes: 1 addition & 1 deletion clifford/_blademap.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def __call__(self, A):
from_b = self.b2
to_b = self.b1
else:
raise ValueError('A doesnt belong to either Algebra in this Map')
raise ValueError('A does not belong to either Algebra in this Map')

# create empty MV, and map values
B = to_b[0]._newMV(dtype=int)
Expand Down
2 changes: 1 addition & 1 deletion clifford/_conformal_layout.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def up(self, x: MultiVector) -> MultiVector:
new_val[:len(old_val)] = old_val
x = self.MultiVector(value=new_val)
except(AttributeError):

Check failure on line 69 in clifford/_conformal_layout.py

View workflow job for this annotation

GitHub Actions / lint | Python 3.8

E275 missing whitespace after keyword
# if x is a scalar it doesnt have layout but following
# if x is a scalar it does not have layout but following
# will still work
pass

Expand Down
4 changes: 2 additions & 2 deletions clifford/_layout.py
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ def vee_func(self):
"""
Generates the vee product function
"""
# Often, the dual and undual are used here. However, this unecessarily
# Often, the dual and undual are used here. However, this unnecessarily
# invokes the metric for a product that is itself non-metric. The
# complement functions are faster anyway.
rc_func = self.right_complement_func
Expand Down Expand Up @@ -772,7 +772,7 @@ def randomRotor(self, **kwargs) -> MultiVector:
'''
generate a random Rotor.
this is created by muliplying an N unit vectors, where N is
this is created by multiplying an N unit vectors, where N is
the dimension of the algebra if its even; else its one less.
'''
Expand Down
2 changes: 1 addition & 1 deletion clifford/_multivector.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def __setitem__(self, key: Union[tuple, int], value: numbers.Number) -> None:
Implements ``self[key] = value``.
If key is a blade tuple (e.g. (0, 1) or (1, 3)), then set
the (real) value of that blade's coeficient.
the (real) value of that blade's coefficient.
.. deprecated:: 1.4.0
If an integer is passed, it is treated as an index into ``self.value``.
Expand Down
8 changes: 4 additions & 4 deletions clifford/cga.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class Flat(CGAThing):
Typically constructed as method of existing cga, like `cga.flat()`
multivector is accessable by `mv` property
multivector is accessible by `mv` property
Parameters
-----------
Expand All @@ -154,7 +154,7 @@ class Flat(CGAThing):
# could inherent some generic CGAObject class
def __init__(self, cga, *args) -> None:
super().__init__(cga)
self.einf = self.cga.einf # we use this alot
self.einf = self.cga.einf # we use this a lot

if len(args) == 0:
# generate random highest dimension flat
Expand Down Expand Up @@ -193,7 +193,7 @@ class Round(CGAThing):
Typically constructed as method of existing cga, like `cga.round()`
multivector is accessable by `mv` property
multivector is accessible by `mv` property
Parameters
-----------
Expand Down Expand Up @@ -461,7 +461,7 @@ def __init__(self, cga, *args) -> None:
# multivector has improper grade
raise ValueError('bad input')
else:
# arg isnt a multivector
# arg is not a multivector
raise ValueError('bad input')

else:
Expand Down
4 changes: 2 additions & 2 deletions clifford/dpga.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
The Cl(4,4) DPGA also known as `Mother Algebra' of Goldman and Mann. see:
"""
The Cl(4,4) DPGA also known as ``Mother Algebra`` of Goldman and Mann. see:
R(4, 4) As a Computational Framework for 3-Dimensional Computer Graphics
Ron Goldman and Stephen Mann
Expand Down
2 changes: 1 addition & 1 deletion clifford/test/test_degenerate.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def translator(dist, line):
E2 = blades['e2'] # y=0 plane
E3 = blades['e3'] # z=0 plane

# A plane is defined using its homogenous equation ax + by + cz + d = 0
# A plane is defined using its homogeneous equation ax + by + cz + d = 0
def PLANE(a, b, c, d):
return a*E1 + b*E2 + c*E3 + d*E0

Expand Down
4 changes: 2 additions & 2 deletions clifford/tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def omoh(A: Union[Frame, List[MultiVector]], B: Union[Frame, List[MultiVector]])
Returns
---------
out : array of floats
weights on `B`, which produce inhomogenous versions of `B`. If
weights on `B`, which produce inhomogeneous versions of `B`. If
you multiply the input `B` by `lam`, it will fulfill `B = R*A*~R`
Examples
Expand Down Expand Up @@ -417,7 +417,7 @@ def orthoMat2Versor(A, eps=None, layout=None, is_complex=None):
N = len(B)

# if (A.dot(A.conj().T) -eye(N/2)).max()>eps:
# warn('A doesnt appear to be a rotation. ')
# warn('A does not appear to be a rotation. ')
A, layout = mat2Frame(eye(N), layout=layout, is_complex=False)
return orthoFrames2Versor(A=A, B=B, eps=eps)

Expand Down
2 changes: 1 addition & 1 deletion clifford/tools/classify.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class _GradedTypesMeta(type):
override : bool
Used when creating an override of a particular grade, such as
``class Line(Flat[3], override=True)``, which will make ``Flat[3]``
return ``Line`` in future. Each grade can be overriden exactly once,
return ``Line`` in future. Each grade can be overridden exactly once,
and should not be outside of this file.
"""
def __new__(metacls, names, bases, dict, override=False):
Expand Down
2 changes: 1 addition & 1 deletion clifford/tools/g3c/GAOnline.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def add_object(self, mv, mv_type='interp', color='rgb(0,0,0)'):
elif return_val == 7:
self.add_plane(mv, color=color)
else:
raise ValueError('Input object cannot be interpretted as an object.')
raise ValueError('Input object cannot be interpreted as an object.')
else:
raise ValueError(str(mv_type) + ' is not a valid mv_type. You must specify a valid mv_type.')

Expand Down
4 changes: 2 additions & 2 deletions clifford/tools/g3c/cuda.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def apply_rotor_device(mv, rotor, output):

@numba.cuda.jit
def apply_rotor_kernel(mv, rotor, output):
# This does elementwise gp with the input arrays into the ouput array
# This does elementwise gp with the input arrays into the output array
i = numba.cuda.grid(1)
if i < mv.shape[0]:
apply_rotor_device(mv[i, :], rotor[i, :], output[i, :])
Expand Down Expand Up @@ -274,7 +274,7 @@ def adjoint_device(value, output):

@numba.cuda.jit
def gp_kernel(value, other_value, output):
# This does elementwise gp with the input arrays into the ouput array
# This does elementwise gp with the input arrays into the output array
i = numba.cuda.grid(1)
if i < value.shape[0]:
gp_device(value[i, :], other_value[i, :], output[i, :])
Expand Down

0 comments on commit 9e47ec2

Please sign in to comment.