Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXT2KG w/ hotpot_qa.pyGraph Retrieval Example and tech_qa.py HybridRAG e2e workflow example #9992

Open
wants to merge 423 commits into
base: master
Choose a base branch
from

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Jan 29, 2025

TXT2kg docs before their merged into main:
https://pytorch-geometric--9992.org.readthedocs.build/en/9992/modules/nn.html?highlight=txt2kg#torch_geometric.nn.nlp.TXT2KG

example of how to use this in nvidia docker container:
git config --global credential.helper store; huggingface-cli login --token <insert_token>; cd /opt/pyg; pip uninstall -y torch-geometric; rm -rf pytorch_geometric; git clone -b latest-txt2kg https://github.com/pyg-team/pytorch_geometric.git; cd /opt/pyg/pytorch_geometric; pip install .; pip install openai

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 19.44444% with 203 lines in your changes missing coverage. Please review.

Project coverage is 85.68%. Comparing base (08697a7) to head (04959c2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
torch_geometric/nn/nlp/txt2kg.py 13.51% 128 Missing ⚠️
torch_geometric/nn/nlp/llm_judge.py 25.64% 29 Missing ⚠️
torch_geometric/loader/rag_loader.py 16.00% 21 Missing ⚠️
torch_geometric/utils/rag/feature_store.py 15.78% 16 Missing ⚠️
torch_geometric/nn/nlp/llm.py 0.00% 4 Missing ⚠️
torch_geometric/nn/nlp/sentence_transformer.py 20.00% 4 Missing ⚠️
torch_geometric/nn/models/g_retriever.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (19.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9992      +/-   ##
==========================================
- Coverage   86.83%   85.68%   -1.15%     
==========================================
  Files         493      496       +3     
  Lines       33084    33396     +312     
==========================================
- Hits        28729    28616     -113     
- Misses       4355     4780     +425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

puririshi98 and others added 13 commits March 13, 2025 09:33
Successor to
[9666](#9666), this:
- ~~updates the documentation to show how to utilize GNN RAG and~~(now
handled by separate branch)
- updates WebQSP to help serve as a toy example for LargeGraphIndexer.
- fixes issues with LargeGraphIndexer running out of memory by
introducing a default batch size and multithreading ability

~~currently blocked by a bug that causes the g_retriever.py example to
get 1% less accuracy.~~ Bug is due to a fp32 precision issue related to
batch kernels in Huggingface's transformers. Performance difference is
too inconsequential to require a fix.

may also be the cause of low retrieval precision in
#9846

---------

Co-authored-by: Zack Aristei <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Zachary Aristei <[email protected]>
Co-authored-by: Rishi Puri <[email protected]>
Co-authored-by: Rishi Puri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants