Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GKAN #9870

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

danielshin1
Copy link

@danielshin1 danielshin1 commented Dec 15, 2024

Added GKAN: Graph Kolmogorov-Arnold Networks as introduced in paper by Mehrdad Kiamari, and Bhaskar Krishnamachari. and the Kolmogorov-Arnold Network comes from the work https://arxiv.org/pdf/2404.19756 and implementation of kan is here https://github.com/KindXiaoming/pykan.

@puririshi98
Copy link
Contributor

puririshi98 commented Dec 17, 2024

this is good at a high level. however i want to see how it compares to existing work. Can you please update this example:
https://github.com/pyg-team/pytorch_geometric/blob/master/examples/ogbn_train.py#L31
to have a "--gnn-choice" arg parse option, with choices ["sage, gat, gatv3"]. and run all 3 in your environment to see how they compare. Please make the highest test acc the default. I can review a little closer once that initial test is done

@puririshi98 puririshi98 self-requested a review December 17, 2024 23:02
@puririshi98
Copy link
Contributor

puririshi98 commented Dec 18, 2024

also try to get the Ci to be all green (your unit test is failing)

@puririshi98
Copy link
Contributor

@danielshin1, this is a great project, checking in if you still want to get it merged, see above for next steps

@puririshi98
Copy link
Contributor

@danielshin1 circling back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants