-
Notifications
You must be signed in to change notification settings - Fork 3.9k
make coalesce compile friendly
#10522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could add a quick test case that reproduces the issue?
Co-authored-by: Akihiro Nitta <[email protected]>
|
@akihironitta I added a test case, but had to remove the error message as |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10522 +/- ##
==========================================
- Coverage 86.11% 85.08% -1.03%
==========================================
Files 496 510 +14
Lines 33655 35967 +2312
==========================================
+ Hits 28981 30603 +1622
- Misses 4674 5364 +690 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update coalesce to be torch compiled without graph breaks.