Skip to content

Conversation

@ValterH
Copy link

@ValterH ValterH commented Nov 6, 2025

Update coalesce to be torch compiled without graph breaks.

@ValterH ValterH marked this pull request as ready for review November 6, 2025 11:39
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a quick test case that reproduces the issue?

@ValterH
Copy link
Author

ValterH commented Nov 6, 2025

@akihironitta I added a test case, but had to remove the error message as torch._check requires the message to be callable and passing a lambda function causes a graph break during compilation.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.08%. Comparing base (c211214) to head (1bfbbf2).
⚠️ Report is 137 commits behind head on master.

Files with missing lines Patch % Lines
torch_geometric/utils/_coalesce.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10522      +/-   ##
==========================================
- Coverage   86.11%   85.08%   -1.03%     
==========================================
  Files         496      510      +14     
  Lines       33655    35967    +2312     
==========================================
+ Hits        28981    30603    +1622     
- Misses       4674     5364     +690     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants