Removed SAMPLED_OP flag from torch_geometric/typing.py
#10023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbielak
force-pushed
the
dev/pbielak/remove-unused-flag
branch
from
577c555 to
3850381
Compare
pbielak
changed the title
SAMPLED_OP flag from torch_geometric/typing.pySAMPLED_OP flag from torch_geometric/typing.py
|
I think we can keep it IMO. No strong pref. |
|
Also IMO if we don't use a particular code fragment anymore, it should be removed ;) |
pbielak
force-pushed
the
dev/pbielak/remove-unused-flag
branch
from
d1f04aa to
0f59500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SAMPLED_OPflag was used some time ago in the softmax implementation (torch_geometrics/utils/softmax.py) and with commit: d7e03c7 its usage was removed. However, the flag is still present in thetorch_geometric/typing.pyfile.