Make computation of mesh laplacian more efficient #10002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly changes the computation of the mesh laplacian to be more efficient. In essence, the introduced changes are:
All tests pass. In addition, I tested the validity of the changes with random triangulations with 1e2-1e5 nodes while benchmarking. The corresponding benchmarking script is not included in this PR, but can be found here. Since this doesn't change the observable behavior of the code, I did not include a line in the changelog.
The performance improvements vary across architectures and with the number of nodes of the triangulation. Below, you can find the speedup for a given architecture (rows) for different normalization methods (columns) with different numbers of nodes in the mesh (tables). This speedup is of course anecdotal, but the fact that there is speedup seems pretty consistent.