-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support rechunking to seasonal frequency with SeasonalResampler #10519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
dcherian
reviewed
Jul 18, 2025
for more information, see https://pre-commit.ci
dcherian
reviewed
Jul 21, 2025
dcherian
reviewed
Jul 21, 2025
Almost there! I have a couple of small requests. @keewis does this API look like it can work with the |
* main: (46 commits) use the new syntax of ignoring bots (pydata#10668) modification methods on `Coordinates` (pydata#10318) Silence warnings from test_tutorial.py (pydata#10661) test: update write_empty test for zarr 3.1.2 (pydata#10665) Bump actions/checkout from 4 to 5 in the actions group (pydata#10652) Add load_datatree function (pydata#10649) Support compute=False from DataTree.to_netcdf (pydata#10625) Fix typos (pydata#10655) In case of misconfiguration of dataset.encoding `unlimited_dims` warn instead of raise (pydata#10648) fix ``auto_complex`` for ``open_datatree`` (pydata#10632) Fix bug indexing with boolean scalars (pydata#10635) Improve DataTree typing (pydata#10644) Update Cartopy and Iris references (pydata#10645) Empty release notes (pydata#10642) release notes for v2025.08.0 (pydata#10641) Fix `ds.merge` to prevent altering original object depending on join value (pydata#10596) Add asynchronous load method (pydata#10327) Add DataTree.prune() method … (pydata#10598) Avoid refining parent dimensions in NetCDF files (pydata#10623) clarify lazy behaviour and eager loading chunks=None in open_*-functions (pydata#10627) ...
dcherian
reviewed
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
api.rst
users could not use
SeasonResampler
for chunking operations in xarray, despite it being a natural fit for seasonal data analysis. When attemptingds.chunk(time=SeasonResampler(["DJF", "MAMJ", "JAS", "ON"]))
, users encountered obscure errors because the chunking logic was hardcoded to only work withTimeResampler
objects. This limitation prevented efficient seasonal analysis workflows and forced users to use workarounds or manual chunking strategies.Now Added a generalized chunking approach by adding a
resolve_chunks
method to theResampler
base class and updating the chunking logic to work with allResampler
objects, not justTimeResampler
. We also added a_for_chunking
method toSeasonResampler
that ensuresdrop_incomplete=False
during chunking operations to prevent silent data loss. The solution maintains full backward compatibility with existingTimeResampler
functionality while enabling seamless seasonal chunking