-
Notifications
You must be signed in to change notification settings - Fork 339
BUG - Update release workflow permissions #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG - Update release workflow permissions #2162
Conversation
This is ready for review. Ignore the odd |
… into trallard/patch-release-workflow
strange linkcheck failure here: it's an actual ERROR on the kitchen sink page, in among the usual WARNINGs. I can reproduce locally on both Which have been in the docstring of Locally if I change the tox runner to use Py3.13 instead of 3.12 everywhere, the error goes away 🤷🏻 I had the idea to try that because that docstring is not shown in the official Python docs for that function: https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote although that docstring must be coming from elsewhere since the relevant lines are still there in cPython main in any event, since it's a bit out of our control to fix, I'll go ahead and merge without linkcheck success. |
gaaaaaah!
Idea 💡 use Python 3.13 for the linkcheck workflow |
IIUC, I think it needs to be set for |
This is a follow-up to #2077. This PR fixes action permissions to call reusable workflows in our release workflow.
I also pinned the SHA for a workflow I missed in a previous review.