Fix condition before using prebuilt validator/serializer #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1625 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Feb 6, 2025
davidhewitt
requested changes
Feb 6, 2025
src/common/prebuilt.rs
Outdated
| // However, we don't want to use a prebuilt structure from dataclasses if we have a `generic_origin` | ||
| // as this means the dataclass was parametrized (so a generic alias instance), and `cls` in the | ||
| // core schema is still the (unparametrized) class, meaning we would fetch the wrong validator/serializer. | ||
| if (type_ != "model") || (type_ == "dataclass" && schema.contains(intern!(py, "generic_origin"))?) { |
There was a problem hiding this comment.
type_ != "model" will always be True for type == "dataclass", so I think the new boolean logic here is wrong?
There was a problem hiding this comment.
Indeed, seems like it is wrong on main as well, I'll fix it
Viicos
changed the title
'typed-dict' schemas for prebuilt validator/serializer
davidhewitt
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Follow up on #1616.
Related issue number
Checklist
pydantic-core(except for expected changes)