Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Following David's comment: #1551 (review)
Replacing the explicitly imported python
UserWarning
withPyUserWarning
from pyo3. This might slightly improve performance in this case, depending on how pyo3 actually raises warnings. In the worst case it should be the same as the current implementation, so there's no harm doing this.Related issue number
None.
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @sydney-runkle