Skip to content

duckduckgo-search is renamed to ddgs #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

basnijholt
Copy link

Currently, I am seeing warnings like:

/Users/bas.nijholt/agent-cli/.venv/lib/python3.11/site-packages/pydantic_ai/common_tools/duckduckgo.py:68:
RuntimeWarning: This package (`duckduckgo_search`) has been renamed to `ddgs`! Use `pip install ddgs` instead.
  DuckDuckGoSearchTool(client=duckduckgo_client or DDGS(), max_results=max_results).__call__,

Copy link
Contributor

hyperlint-ai bot commented Jul 10, 2025

PR Change Summary

Renamed the duckduckgo-search package to ddgs in the documentation to reflect the recent changes in package naming.

  • Updated installation instructions to use ddgs instead of duckduckgo-search
  • Modified references to the DuckDuckGoSearchRun tool to reflect the new package name
  • Removed warnings related to the old package name in the documentation

Modified Files

  • docs/install.md
  • docs/tools.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

from duckduckgo_search import DDGS
try:
from ddgs import DDGS
except ImportError: # Fallback for older versions of ddgs
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could skip this try-except.

Currently, I am seeing warnings like:
```
/Users/bas.nijholt/agent-cli/.venv/lib/python3.11/site-packages/pydantic_ai/common_tools/duckduckgo.py:68:
RuntimeWarning: This package (`duckduckgo_search`) has been renamed to `ddgs`! Use `pip install ddgs` instead.
  DuckDuckGoSearchTool(client=duckduckgo_client or DDGS(), max_results=max_results).__call__,
```
@fswair
Copy link
Contributor

fswair commented Jul 10, 2025

...

@DouweM
Copy link
Contributor

DouweM commented Jul 10, 2025

If user installs latest version of pyai, also gets the latest version of duckduckgo

@fswair Only if they used the duckduckgo optional dependency group to install it, rather than installing it directly. I think the extra import attempt is fine so we don't break existing installations.

@DouweM
Copy link
Contributor

DouweM commented Jul 10, 2025

@basnijholt The linter is not loving it though 😅 Can you have a look to see what's going on?

@fswair
Copy link
Contributor

fswair commented Jul 10, 2025

@basnijholt The linter is not loving it though 😅 Can you have a look to see what's going on?

Then @basnijholt may you add some pyright ignore directives in the lines that causes lint errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants