Repository navigation
check traditional dsa private keys match their public key - #16008
Open
jmestwa-coder wants to merge 1 commit into
Open
jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traditional DSA private keys are not checked against their public key
The
DSA PRIVATE KEYloader passes the storedystraight through, so a key whoseyis notg^x mod ploads and reports a public key that does not verify its own signatures, while the PKCS8 loader,DSAPrivateNumbers.private_key()and the SSH loader (see #15881) already reject it. It now raisesValueErroron mismatch;test_nilpotentnow expects the load to fail, since that vector storesy = 1whileg^x mod pis 0.