Feature EV3 firmware flash - minor improvements #2347
Conversation
afarago
force-pushed
the
feature-ev3-firmware-flash
branch
from
59e70c7 to
9d52d9d
Compare
src/usb/sagas.ts
Outdated
| if (!usbDevice.configuration && usbDevice.configurations.length > 0) { | ||
| const [, selectErr] = yield* call(() => | ||
| maybe( | ||
| usbDevice.selectConfiguration( | ||
| usbDevice.configurations[0].configurationValue, | ||
| ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
| if (!usbDevice.configuration && usbDevice.configurations.length > 0) { | |
| const [, selectErr] = yield* call(() => | |
| maybe( | |
| usbDevice.selectConfiguration( | |
| usbDevice.configurations[0].configurationValue, | |
| ), | |
| ), | |
| ); | |
| if (usbDevice.configuration === null) { | |
| const [, selectErr] = yield* call(() => | |
| maybe(usbDevice.selectConfiguration(1)), | |
| ); |
Since we control the firmware, we know that we always want configuration 1, which may or may not be the configuration at index 0.
And prefer strict equality checks instead of truthy/falsy unless there is a good reason for it.
There was a problem hiding this comment.
ok, corrected.
Any comment or assert to document this "magic" number?
Concern: code-logic wise this could even break, only works as you control the firmware.
There was a problem hiding this comment.
There are probably a few other hard-coded USB things that we need to clean up like this. Agree that it would be sensible to make a constant for this. But we can save that for later.
That is a fair comment. :D Apologies for my back-and-forth's. |
|
I'll fix up the commits how I like them and merge this. |
Fix issues with null vs. undefined. Based on DefinitelyTyped/DefinitelyTyped#73568
On some OSes, like macOS, the configuration may not be selected, so we need to make sure it is always set.
Dispatch an error in case there is no firmware URL. Normally this should never happen, but currently it does because we don't have EV3 firmware yet. The error is more useful than just spinning forever.
The v2.1 spec allows this, but up to now, Pybricks code didn't handle it.
Start listening for reply before sending command to avoid race condition of reply being received and action dispatched before we call take().
Implement unique message ID for EV3 firmware messages.
Add missing bits to get firmware flashing on EV3 working. Currently requires custom firmware since we don't have a packaged one yet.
dlech
force-pushed
the
feature-ev3-firmware-flash
branch
from
8edc14a to
311a833
Compare
For some reason, the type checker doesn't catch this, but FailToFinishReasonType.Unknown requires an error argument, otherwise we get an unhandled exception.
|
Still lots to do, but nice to handle it in smaller chunks like this. Thanks! |
Minor implementation changes to make pybricks/support#2318 work