chore(tools): make_changelog missed and resurrected PRs#6108
Open
henryiii wants to merge 3 commits into
Open
Conversation
Three unrelated causes made the generated changelog wrong: - Requests were unauthenticated, so GitHub returned "Cache-Control: public" and a shared CDN cache supplied stale PR bodies. Send a token from GITHUB_TOKEN, GH_TOKEN, or `gh auth token`. - The heading regex required a trailing colon, so a PR that wrote "## Suggested changelog entry" without one was reported as missing. - The server-side label filter lags behind label removals by many minutes, so PRs that no longer have the label came back. Re-check the label on each issue. Also update to ghapi>=2 and its sync API. Assisted-by: ClaudeCode:claude-opus-5
Assisted-by: ClaudeCode:claude-opus-5
henryiii
changed the title
Only the main categories are listed now. A conventional commit scope on the title, such as "fix(cmake):", becomes a group inside its main category, sorted alphabetically after the entries that have no scope. The main heading also prints when a category holds only scoped entries. Assisted-by: ClaudeCode:claude-opus-5
Collaborator
|
@claude review this PR |
1 similar comment
Collaborator
Author
|
@claude review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
nox -s make_changelogskipped some PRs, showed old descriptions for others, and listed PRs whose label was already removed. There were three separate causes:Cache-Control: publicand a shared CDN cache supplied old descriptions. The script now sends a token fromGITHUB_TOKEN,GH_TOKEN, orgh auth token. This also raises the rate limit from 60/hr to 5000/hr, which pagination needs.## Suggested changelog entrywithout one was reported as missing. The colon is now optional.labels=list filter is eventually consistent and lagged a label removal by more than 20 minutes, even authenticated and with a cache-busting parameter. Each issue's ownlabelsarray is now re-checked on the client.Two more changes on top:
fix(cmake):becomes a group inside its main category, printed under<!-- fix(cmake) -->and sorted alphabetically after the entries that have no scope. The main heading also prints when a category holds only scoped entries, whichfeat(subinterpreter)did not get before. A breaking-change!in the prefix is accepted.Also moves to
ghapi>=2and its sync API.Checked against the current label set: the false "missing" reports and the resurrected PRs are gone, and the remaining reports are PRs that really have no changelog heading.
Suggested changelog entry: