fix(ci): use the intended Python interpreter for CMake discovery#6105
Merged
Conversation
The manylinux/musllinux images added Python 3.15 and dropped 3.13t; FindPython's version scan then picked /usr/local/bin/python3.15 over the uv-created venv (Python_ROOT_DIR is only a hint). Similarly, the macOS and Windows 3.14t jobs picked a system 3.14 over setup-python's free-threaded interpreter. Pin the interpreter explicitly in both places, and drop the 3.13t manylinux jobs. Assisted-by: ClaudeCode:claude-fable-5
Assisted-by: ClaudeCode:claude-fable-5
Collaborator
|
I just triggered a rerun of the failed 🐍 (ubuntu-latest, 3.13, -DCMAKE_CXX_STANDARD=23 -DPYBIND11_SIMPLE_GIL_MANAGEMENT=ON) / 🧪 job, to see if it is a flake. EDIT: The rerun succeeded: 🐍 (ubuntu-latest, 3.13, -DCMAKE_CXX_STANDARD=23 -DPYBIND11_SIMPLE_GIL_MANAGEMENT=ON) / 🧪 |
rwgk
approved these changes
Jul 24, 2026
rwgk
left a comment
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Suggested revised title:
fix(ci): use the intended Python interpreter for CMake discovery
All suggestions aim to avoid using the term "pin", it doesn't seem quite fitting.
Thanks for taking care of this!
henryiii
changed the title
Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
CI has been red since the manylinux/musllinux images added Python 3.15 and dropped 3.13t, and the same runner refresh broke the free-threaded jobs on macOS and Windows:
uvcreates the requested venv, butPython_ROOT_DIRis only a hint: FindPython's version scan tries 3.15 first and finds/usr/local/bin/python3.15on PATH before considering the venv's older interpreter. All four jobs then built against 3.15 and failed at the pytest step (No module named pytest).Fixes:
CMakeLists.txt: when the venv machinery setsPython_ROOT_DIR, also pinPython_EXECUTABLEto the venv's interpreter, making discovery exact instead of heuristic.reusable-standard.yml: pass setup-python's interpreter to CMake as-DPYTHON_EXECUTABLE(works in both old and new FindPython modes).ci.yml: drop the 3.13t manylinux rows; the images no longer ship 3.13t, and 3.14t rows already exist.Suggested changelog entry: