-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: bind noexcept and ref-qualified methods from unregistered base classes #5992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Skylion007
wants to merge
16
commits into
pybind:master
Choose a base branch
from
Skylion007:skylion007/cpp17-claude-noexcept-2026-02-20
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bd45ad0
Strip noexcept from cpp17 function type bindings
Skylion007 b303194
Fix a bug and increase test coverage
Skylion007 f530adb
Does this fix it?
Skylion007 70170b0
Silence clang-tidy issue
Skylion007 ba63458
Simplify method adapter with macro and add missing rvalue adaptors + …
Skylion007 48f561f
Supress clang-tidy errors
Skylion007 f9863d1
Improve test coverage
Skylion007 a329095
Add additional static assert
Skylion007 0e0669d
Try to resolve MSVC C4003 warning
Skylion007 b6092e9
Simplify method adaptor into 2 template instatiations with enable_if_t
Skylion007 e4ece99
Fix ambiguous STL template
Skylion007 798e516
Close remaining qualifier consistency gaps for member pointer bindings.
rwgk 35584e0
Clarify why def_buffer/vectorize omit rvalue-qualified overloads.
rwgk 94e6b4b
Add compile-only overload_cast guard for ref-qualified methods.
rwgk 3914a28
Refactor overload_cast_impl qualifier overloads with a macro.
rwgk cd6ef9d
Expose __cpp_noexcept_function_type to Python tests and use explicit …
rwgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I normalize it here for all pybind11? Or keep it as utility that and create a new alias that always strips the noexcept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the flip side we could use the noexcept tag handling to optimize away exception handling for certain edge cases like def_buffer maybe?