Factor out pybind11/gil_simple.h #5614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b-pass Could you please review (and approve if it looks good to you)? |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long overdue, straightforward refactoring, eliminating code duplication in pybind11/detail/internals.h
Current motivation: Simplify PR #5564
Subtle API change (does NOT require any production code changes):
disarm()member functions are removed fromgil_scoped_acquire_simpleandgil_scoped_release_simple.This means,
PYBIND11_SIMPLE_GIL_MANAGEMENTis no longer compatible with uses ofdisarm(). However, this is strictly an improvement, because the removed member functions were no-ops. — Note also that thedisarm()functions are used only in very rare cases.See also ChatGPT's take on
usingvs inheritance: https://chatgpt.com/share/67fc24a7-c4bc-8008-aa9b-b82c4909e0b4Suggested changelog entry: