Move pybind11 from submodule to pyproject.toml:build-system.requires. #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can specify setup dependencies in pyproject.toml, pybind11 could be added here instead of placed directly under the root of the repo, which make the repo structure more compact. And the path of pybind11 cmake config could be set by pybind11_DIR in setup.py.
|
Is there any body know how to install pybind11 when checking format in precommit? |
|
Yes, you can add it to the .pre-commit-config.yaml file. See https://learn.scientific-python.org/development/guides/style/#type-checking. On the pyproject.tmol, this is shown in the scikit_build_core example, and new projects should really be using that instead, and having different mechanisms broadens the overall scope of the examples. Though I think it does make sense here, so I'd still be in favor. Can see if any other maintainers have opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can specify setup dependencies in pyproject.toml, pybind11 could be added here instead of placed directly under the root of the repo, which make the repo structure more compact. And the path of pybind11 cmake config could be set by pybind11_DIR in setup.py.