Skip to content

docs: fix mistakes on mentions to how dependencies are defined in pyproject.toml #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

flpm
Copy link
Member

@flpm flpm commented Sep 21, 2024

Several fixes in the references to how optional dependencies are added in pyproject.toml.

I found these issues when reviewing the Spanish translation PR #336

@flpm flpm marked this pull request as draft September 21, 2024 18:02
@flpm flpm force-pushed the fix-reference-to-dependencies branch from 7f8d541 to dee43cc Compare September 21, 2024 18:21
@flpm flpm changed the title Fix reference on how to add dependencies in pyproject.toml Fix mistakes on mentions to how dependencies are defined in pyproject.toml Sep 21, 2024
@flpm flpm marked this pull request as ready for review September 21, 2024 18:47
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop nice catch

@tkoyama010 tkoyama010 changed the title Fix mistakes on mentions to how dependencies are defined in pyproject.toml docs: fix mistakes on mentions to how dependencies are defined in pyproject.toml Sep 21, 2024
@flpm flpm merged commit 41866f9 into pyOpenSci:main Sep 24, 2024
4 checks passed
@flpm flpm deleted the fix-reference-to-dependencies branch September 24, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants