Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 94.07% 94.13% +0.06%
==========================================
Files 5 5
Lines 287 290 +3
==========================================
+ Hits 270 273 +3
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Defenitely more readable, I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesI recently discovered namedtuple, and I think we could make use of it in many places.
For example, accessing sigma on the t grid doing
sigmas.tseems more robust (and readable?) thansigmas[0].We could use it for pps as well (e.g., place all tanh2 parameters in a named tuple and access those like this
pp_tanh2.a2).