fix timer conflict between rotary encoder and audio output (again) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Andy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conflict between timers used by the rotary encoder and audio output prevents them from being used at the same time
This problem was originally found and discussed here
It was fixed with commit 93a6611 in the v1.8.1 release
Looking through the git history, I am confused/stumped as to where the code regressed.
From what I can tell the next time
hardware.pywas changed was in ce964c3, but the regression back to the older list of timers isn't marked as a change...Likewise, from what I can tell, the next time
audio.pywas changed was in 457c28e, but that commit shows that audio is back to using timer 2, and it is not marked as a change...Anyway, I reimplemented the same changes as from 93a6611