Try to support numpy version 2 #969
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueDrink9
commented
May 8, 2025
|
I'm a bit confused by the lkg.txt files, how do we regenerate those? |
|
|
BlueDrink9
force-pushed
the
np2
branch
3 times, most recently
from
82651c4 to
1894bdd
Compare
|
A bunch of the continuous integration steps will need to be updated to use a later version of python rather than 3.8 as part of this |
Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
…nsion Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
They are read-only in modern numpy Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
This reverts commit 687f343. Not actually needed, resolver should take care of it Signed-off-by: bluedrink9 <[email protected]>
Signed-off-by: bluedrink9 <[email protected]>
|
Passing tests with a lot of warnings https://github.com/BlueDrink9/EconML/actions/runs/14917865406/job/41907412454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is well and truly in draft mode, and may never get off the ground without some serious decision making. As such, I'm not really expecting this to have this merged, but perhaps the work that I have done here might be helpful for someone else down the line.
Numpy 2 does not support python 3.8, which straightaway rules out some of the optional dependencies that EconML has (eg pytorch). To get it building and testing, I have just removed them, and so it would probably require some more work if it was desirable to keep those.
I'm not experienced with cython, and a lot of the cython code here was not particularly clear to me from the sparse comments, so most of what I've done is really on a best guess effort to get it to successfully compile and pass tests. I'm still working on getting the remaining warnings fixed, but it would definitely benefit from help from someone who actually understands cython/the numpy API .
That being said, some of the tests are failing with segfaults so clearly I have made some mistakes somewhere. I have highlighted where I think these most likely are, but it will need someone who actually understands cython/the numpy API to assess and fix.