Skip to content

Add sensitivity analysis methods #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 22, 2025
Merged

Add sensitivity analysis methods #967

merged 15 commits into from
May 22, 2025

Conversation

fverac
Copy link
Collaborator

@fverac fverac commented Apr 17, 2025

No description provided.

@fverac fverac requested a review from kbattocchi April 28, 2025 17:06
@fverac fverac marked this pull request as ready for review April 28, 2025 17:06
kbattocchi
kbattocchi requested changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, a few small comments and corrections.

kbattocchi
kbattocchi requested changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nearly there, just a few more minor changes needed. Also, as discussed offline it would be good to add an entire section on sensitivity analysis to the docs, though that can go in a separate PR.

fverac added 4 commits May 9, 2025 11:51
@fverac
minor fixes
d6eb27b 
Signed-off-by: Fabio Vera <[email protected]>
@fverac
fix tests
819b8cb 
Signed-off-by: Fabio Vera <[email protected]>
@fverac
fix drlearner sensitivity calc, address edge case
064453a 
Signed-off-by: Fabio Vera <[email protected]>
@fverac
remove comment
a75dd6c 
Signed-off-by: Fabio Vera <[email protected]>
kbattocchi
kbattocchi approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some additional feedback, but feel free to merge once you feel it's ready.

fverac added 3 commits May 20, 2025 09:58
@fverac
minor refactor to simplify logic
ab0d9c2 
Signed-off-by: Fabio Vera <[email protected]>
@fverac
fix errors, addnl refactoring
a23195a 
Signed-off-by: Fabio Vera <[email protected]>
@fverac
refactor again
c972c7a 
Signed-off-by: Fabio Vera <[email protected]>
@fverac fverac merged commit 2515de8 into main May 22, 2025
93 checks passed
@fverac fverac deleted the fverac/sensitivity_analysis branch May 22, 2025 14:56
carl-offerfit pushed a commit to carl-offerfit/EconML that referenced this pull request Jul 7, 2025
@fverac
Add sensitivity analysis methods (py-why#967)
992eca0 
Signed-off-by: Carl Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fverac @kbattocchi