Rename time information APIs to be Django-compliant #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, but it does make I'm fine to wait indefinitely before merging this, if compatibility is a concern. |
The following `MinioStorage` methods are renamed: * `accessed_time` -> `get_accessed_time` * `created_time` -> `get_created_time` * `modified_time` -> `get_modified_time` Additionally, `get_accessed_time` and `get_created_time` now raise `NotImplementedError`, as this information is not available from Minio. See: https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_accessed_time https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_created_time https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_accessed_time Fixes py-pa#83.
|
maybe we can the old methods and document that the old ones are deprecated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following
MinioStoragemethods are renamed:accessed_time->get_accessed_timecreated_time->get_created_timemodified_time->get_modified_timeAdditionally,
get_accessed_timeandget_created_timenow raiseNotImplementedError, as this information is not available from Minio.See:
https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_accessed_time https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_created_time https://docs.djangoproject.com/en/5.2/ref/files/storage/#django.core.files.storage.Storage.get_accessed_time
Fixes #83.