Skip to content

Allow user to provide unsafe headers #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow user to provide unsafe headers #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/001-xml_http_request.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ class XMLHttpRequest extends XMLHttpRequestEventTarget
# @throw {SyntaxError} name is not a valid HTTP header name or value is not
# a valid HTTP header value
# @see http://www.w3.org/TR/XMLHttpRequest/#the-setrequestheader()-method
setRequestHeader: (name, value) ->
setRequestHeader: (name, value, allowUnsafeHeaders = false) ->
unless @readyState is XMLHttpRequest.OPENED
throw new InvalidStateError "XHR readyState must be OPENED"

loweredName = name.toLowerCase()
if @_restrictedHeaders[loweredName] or /^sec\-/.test(loweredName) or
/^proxy-/.test(loweredName)
if (!allowUnsafeHeaders and (@_restrictedHeaders[loweredName] or /^sec\-/.test(loweredName) or
/^proxy-/.test(loweredName)))
console.warn "Refused to set unsafe header \"#{name}\""
return undefined

Expand Down