Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add - Anonymous Chat #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gokulkrishh
Copy link

Contain

  1. Manifest.json
  2. Service Worker
  3. Add to home screen
  4. Served via https
  5. Static assets are cached

Site: https://anonymouschat.in

@pepelsbey
Copy link

Thank you for suggestion! But all I see so far is a spinner

image

How this suppose to work? Imagine someone browsing this list looking for a good example of PWA, what would this person think when they see an endless spinner and no explanation whatsoever?

@pepelsbey
Copy link

Could you please also update your fork with the latest changes from upstream so qrcode-scanner won’t be presented in your current PR? It’s already merged.

@gokulkrishh
Copy link
Author

gokulkrishh commented Aug 16, 2016

@pepelsbey Hey, I understood your concern. I will add an intro screen for user, only for first time visit. So they can understand about app.

B/W I have done the fetch from upstream. Not sure why i got some previous commits. I will do the fetch again and update.

Thanks for the feedback!!

@pepelsbey
Copy link

pepelsbey commented Aug 16, 2016

Ok, now I finally see the chat but it takes up to a minute (or sometimes more) of looking at spinner before it goes live. Also input is hidden in Safari so it’s not clear what to do here (see below). It’s also not clear how this thing works: how am I supposed to invite someone here, is it just a single chat room for everyone? A little question mark icon with explanation would make it much better.

img_6395

@pepelsbey
Copy link

It’s slow in all browsers I used (Safari, Opera, Chrome, mobile and desktop), so it’s probably related to my location: St. Petersburg, Russia.

@gokulkrishh
Copy link
Author

gokulkrishh commented Aug 16, 2016

@pepelsbey It's a 1 on 1 chat application which connects with users randomly. I will add info in intro screen or similar to how you are suggesting.

Also, app size is 787 KB and attaching the devTool network screen. Might be due to slow connection or something.

screen shot 2016-08-16 at 3 26 09 pm

Will do the fix for safari input hidden 👍

@pepelsbey
Copy link

It's a 1 on 1 chat application which connects with users randomly

It wasn’t clear at all, worth adding.

@gokulkrishh
Copy link
Author

gokulkrishh commented Aug 22, 2016

@pepelsbey Done. I have added a popup with info about this app.

screen shot 2016-08-22 at 9 59 12 am

Also removed the old commits and rebased with master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants